Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run rosetta tests against local kava network #69

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

evgeniy-scherbina
Copy link
Contributor

@evgeniy-scherbina evgeniy-scherbina commented Aug 1, 2024

Overview

PR adds a new CI workflow: Run Tests Against Local Kava Network, which is run on every rosetta-kava commit. In the future it will be run on every kava commit as well.

A new CI workflow is based on already existing CI workflow: https://github.com/Kava-Labs/rosetta-kava/blob/master/.github/workflows/ci.yml. Main difference that new CI workflow is fully automated and run against local kava network, while old workflow requires manual intervention and run against testnet or mainnet.

New workflow consists of the following steps:

  • run kava node with kvtool
  • run two instances of rosetta-kava, one in online mode, another in offline mode
  • execute integration tests
  • execute check:construction
  • execute check:data

NOTE: all tests are executed against local kava-node

Implementation details

Configuration files

PR adds a new folder rosetta-cli-conf/kava-localnet-ci which was created based on rosetta-cli-conf/kava-testnet-ci.

Main changes are:

  • removing of cache directory, all tests are run from scratch every time, we don't need start where it last left off functionality
  • using of different ports for online and offline URLs
  • using of another predefined account, new predefined account is a kvtool whale account

Scripts

PR adds a new folder .github/scripts/kava-localnet-ci, which contains 3 scripts:

  • setup.sh - starts 2 instances of rosetta-kava
  • construction.sh- runs check:construction
  • cli.sh - runs check:data

Newly added scripts are based on already existing ones: https://github.com/Kava-Labs/rosetta-kava/tree/master/.github/scripts and modified to work with local kava network.

Questions

  1. for check:data we run it against latest 10 blocks, should we adjust this number?
  2. I think mostly these blocks are empty, should we simulate some load, some transactions?

Follow-up PRs:

@evgeniy-scherbina evgeniy-scherbina force-pushed the process_kava_dispatch branch 18 times, most recently from 16f4c9c to 4811fc6 Compare August 13, 2024 13:52
@evgeniy-scherbina evgeniy-scherbina changed the title Added process_kava_dispatch workflow Run rosetta tests against local kava network Aug 13, 2024
@evgeniy-scherbina evgeniy-scherbina marked this pull request as ready for review August 13, 2024 18:01
@evgeniy-scherbina evgeniy-scherbina merged commit 846aca5 into master Aug 14, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant